From: Florian Müllner <fmuellner@gnome.org>
Date: Thu, 9 May 2024 12:01:26 +0000 (+0200)
Subject: unlockDialog: Bind source titles
X-Git-Tag: archive/raspbian/50.5-1+rpi1~1^2~226^2^2~179
X-Git-Url: https://dgit.raspbian.org/%22http://www.example.com/cgi/%22/%22http:/www.example.com/cgi/%22?a=commitdiff_plain;h=fe24de3ef2b96ce82f3eddd2fc7ec87d6ea70ed2;p=gnome-shell.git

unlockDialog: Bind source titles

After the recent notification changes, the title may still be null
when the source is originally added. Handle that case and make sure
we pick up later title changes by setting up a property binding.

Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/3308>
---

diff --git a/js/ui/unlockDialog.js b/js/ui/unlockDialog.js
index 7b2ab8d38..f741b20a6 100644
--- a/js/ui/unlockDialog.js
+++ b/js/ui/unlockDialog.js
@@ -96,11 +96,13 @@ const NotificationsBox = GObject.registerClass({
         box.add_child(textBox);
 
         let title = new St.Label({
-            text: source.title,
             style_class: 'unlock-dialog-notification-label',
             x_expand: true,
             x_align: Clutter.ActorAlign.START,
         });
+        source.bind_property('title',
+            title, 'text',
+            GObject.BindingFlags.SYNC_CREATE);
         textBox.add_child(title);
 
         let count = source.unseenCount;
@@ -127,9 +129,13 @@ const NotificationsBox = GObject.registerClass({
         box.add_child(textBox);
 
         let title = new St.Label({
-            text: source.title.replace(/\n/g, ' '),
             style_class: 'unlock-dialog-notification-label',
         });
+        source.bind_property_full('title',
+            title, 'text',
+            GObject.BindingFlags.SYNC_CREATE,
+            (bind, sourceVal) => [true, sourceVal?.replace(/\n/g, ' ') ?? ''],
+            null);
         textBox.add_child(title);
 
         let visible = false;